"Encrypt Wallet" in Zecwallet-Lite, pros / cons and whether this feature is worth using

[BrunchTime]

@tromer and @adityapk00 make good points about this feature here:

[POLL] Do you expect wallet encryption to preserve your privacy?

Old versions of Zecwallet Lite (the QT version) did have full wallet encryption. I came to realize that it was a horrible idea, and removed it. if the machine is compromised with malware, the funds are going to be lost anyway, as the malware is likely going to watch you type your wallet password. (keyloggers) users regularly forgot their password, and then asked me to help them recover funds. a fully encrypted wallet can’t sync (because the wallet doesn’t have viewing keys), and people got ups…