Shielded Support for Ledger Hardware Wallets (NanoS+, NanoX)

Not detrimental to this grant, but hasn’t ZingoLabs forked these repos already? Would they be able to integrate this PR that’s already been in the works? or has time passed so much that it’s unfeasible?

3 Likes

I believe Zingo has only released mobile apps (which also works on Apple silicon computers). I assume the integration needs to be done on a desktop app.

1 Like

We’ve been looking into rebooting the desktop app, I don’t think it’s gotten much further than the “Hey, it would be cool to do this” stage at the moment. James Katz recently put some work into rebooting zingo-pc, although the repo was archived a week ago. @zancas might be able to say more on this, I’ve been really focused on prototyping what we’re calling memo-sync recently (which will enable much more rapid rescan/restore from seed), and he has a more holistic view on what zingolabs as a whole is up to.

2 Likes

We intend to republish a desktop offering for power-users/developers who are willing to build software from github.

We have invested some time in this already (building on @james_katz 's excellent start).

We are not committed to a timeline.

4 Likes

I’d say the cost of not having reliable shielded hardware support is much greater than the cost of this grant.

Getting Ywallet to work with Ledger would:
-Allay the constant criticism that Zcash doesn’t have shielded hardware support
-Provide a safer solution to storing larger amounts of shielded ZEC, potentially increasing the size of the shielded pool. This would not only increase Zcash’s privacy properties but demonstrate to the world “people are using shielded ZEC”.
-If significantly adopted, perhaps show to others (ahem, Trezor) that Zcash shielded hardware support is a product worth having, not only for financial privacy, but for their bottom line.

Also, there is little risk of the technical side of things getting done, just look at @hanh’s track record. As others have brought up, the risk seems to be on the integration and platform-support side of things. But with a plug-and-play solution that has little resource demand on Ledger’s team, combined with high-level lobbying (aka pressure), it seems like a bet worth taking that this would get across the finish line.

11 Likes

@hanh & Zcash Community, the @ZcashGrants Committee has unanimously voted to approve this grant.

25 Likes

Thanks @ZcashGrants

As discussed with the committee, Zondax will not be involved after all. The grant submission will be updated to reflect this decision.

9 Likes

Congratulations @hanh this will be monumental for zcash

Thanks, also to be clear, I will not use the Zondax code in order to avoid any potential issue with IP.

3 Likes

Excellent, looking forward to this one!

@hanh how will not using Zondax work Alter the delivery timeline?
Really pleased to see this was funded, one of the most important things we need for usability/adoption along with the work ECC are doing on syncing, mobile SDK’s etc

3 Likes

The code is written from the ground up specifically for zcash. It should turn out to be smaller and faster. Therefore, I hope to save time during the integration phase.

14 Likes

My Ledger app can derive the keys and address internally and display on the device screen.

zcash-ledger

20 Likes

@hanh ur a wizard - wen this launches all Zcash community will thank you

3 Likes

Is there any chance this could ever run on a nano S?

1 Like

I think it will because my app is smaller than the bitcoin app.

12 Likes

Quick demo of the import/connect function

15 Likes

@hanh I’m excited to audit your Ledger code! I’m just wrapping up an audit of the Zondax code so I might have some suggestions that will be useful. I’ll get in touch once I’m done writing up that report. One thing I can say right away is that the more of it that’s Rust, when that’s do-able within the memory constraints, the easier it will be to audit. :slight_smile:

9 Likes

It is 0% rust.

I posted a video on Ledger app security & scalability. @earthrise This may be of interest to you.

9 Likes

z2z transactions work now.

They can be as large as you want (if you are patient) and contain memos.

28 Likes