Shielded Support for Ledger Hardware Wallets (NanoS+, NanoX)

[zkcroc]

@hanh just to confirm, this app will NOT fit onto a ledger nano S? Just asking if i have to upgrade or not

[hanh]

It will NOT fit in a Nano S. Orchard is way too complex.

[den]

Making the impossible happen @hanh ?

Hanh Huynh Huu

[hanh]

NanoS supports Transparent and Sapling.

I barely managed to make it fit. Less than 100 bytes of RAM left and that’s after manually optimizing the code size by looking at the generated assembly code…

We need testers! If you have a NanoS, or S+ and are proficient with using the command line, you can help by using YWallet 1.4.0 & Ledger.

[hloo]

I tested it tonight on an old NanoS and it worked great!

Here’s a fully shielded Sapling transaction sent from a NanoS:

Zcash / Transaction /...

[hanh]

Thanks!

One cool feature is that transactions aren’t limited in size even on the Nano S.
For example, this one has 6 shielded inputs and 5 shielded outputs.

It is because the tx builder & signer, are streaming.

To my knowledge, that is a first for any wallet/coin.

https://zcashblockexplorer.com/transactions/47bc10c6434838dcd013bf80a0d3f27dc8670c64e4c58400aa1a1bf07c947d06

[octalmage]

Just tested this with 1.4.0 and the v1.0.1 zcash-ledger app.

Worked incredibly, really appreciate your work on this!

here’s my versions:

My only feedback is that while signing, the ledger screen flickered a few times? I wasn’t sure if that was intended, but either way it works.

Thanks again!

[octalmage]

Ledger Nano S+ clear edition if that matters.

[hanh]

Thanks, the app shows different status messages such as processing z-out, etc. The screen may flicker because some of these states don’t last long.

[zkcroc]

Does anyone have an ear into ledger HQ about this? the activity in the airtable link seems pretty stagnant?

[Blazin8888]

Will this be working on a nano X any time soon?

[cybrowl]

Will buy S+ and test. Seems cool. Good work

[pkr]

@SexDrugsAndZcash

the Ledger integration and the situation with Hanh

@Dodger please share the status of where this stands.

[aquietinvestor]

@pkr

share the status of where this stands.

@pkr - ZCG has been in touch with Ledger. There will be a detailed status update in our 09/18 meeting minutes, which will be published to the forum early next week.

[pkr]

Thank you @aquietinvestor for the quick reply. Looking forward.

[aquietinvestor]

Please see the below update, which summarizes where things stand with Ledger. We are in close contact and will provide additional updates as the situation evolves.

@ZcashFoundation

Ledger - ZCG had a call with a few Ledger team members. They discussed Hanh’s proposal and past Zondax projects.

• Brian gave a summary of the Ledger call:
  • Ledger is very interested in supporting Zcash shielded transactions. They say there is persistent demand for Zcash support on Ledger devices and they would like to see progress made soon.
  • Ledger was unaware that ZCG and ZF are two distinct grant allocating bodies, but ZCG cleared up that two different teams have been working on Ledger integration.
  • Ledger is indifferent towards working with Hanh or Zondax. They noted their existing relationship with Zondax, spoke well of them, and reiterated Zondax’s experience with Ledger’s expectations and Ledger Live. Ledger wants ZCG to make the decision regarding who submits the app.
  • High-level discussion on Ledger’s concerns they had with Hanh’s proposal.
    • Ledger doesn’t care who submits the application, but believe it’s better for a blockchain-based organization to submit because an org is better suited to provide long-term support for the app.
    • One option is for ZCG or ZF to co-apply with Hanh to serve as a backing organization that could potentially provide funding for support if Hanh was to stop supporting the app.
    • Ledger also voiced that the developers behind the application should be KYC’d, which is not an issue as Hanh is already a grant recipient.
    • Ledger wants to ensure a long-term agreement for supporting and maintaining the app.
  • Other requirements Ledger noted: the app must be user-friendly, Ledger Live compatible with shielded Zcash transactions, and the app should also be able to be used by third parties and YWallet.
• The committee had a follow-up call with Hanh to discuss these asks/requirements. Brian gave a summary of that call:
  • Most concerns were addressable by Hanh aside from some technical concerns like Ledgerlive and shielded Zcash.
  • Hanh has some questions about the integration with Ledger Live, specifically related to sync capabilities and the design parameters.
  • The next step is to have a call with Hanh, the Ledger team, and ZCG to discuss all concerns from both parties and next steps.
• Jason emphasized that Hanh being an individual developer is not a dealbreaker for Ledger. Ledger’s concern is that if Hanh stops supporting the app, there is still an organization that can provide funding or find another developer who can support and maintain the app. This is ZCG’s role. The best path forward would be for ZCG (or ZF) to co-apply with Hanh, if possible.
• Alex said that ZCG is a committee under ZF and doesn’t have the ability to enter into agreements on its own. He asked what sort of commitment was discussed with Ledger. Jason and Brian said that they would have a better idea once they receive the application from Ledger and will follow up with ZF on next steps.

[conradoplg]

It’s critical to discuss with Ledger the ZIP-32 compatibility issue and if they’re willing to add support for ZIP-32 path derivation

[hanh]

Could you clarify why you think it is critical?

[conradoplg]

Without that there would be effectively two types of seeds, which would require users to pick which one when restoring a wallet (and would lead to endless confusion and topics about funds appearing to be lost when people inevitably pick the wrong choice) or scanning with both paths which would make wallets twice as slow. Both seem pretty bad.

[hanh]

That’s the case with trezor on multiple coins: eth, xmr, ada… Reddit - Dive into anything
It doesn’t seem to be a critical issue to me. One should not share his seed between devices, especially a hardware wallet.